On Thu, 13 Mar 2025 23:53:34 -0400
Eli Schwartz <eschwa...@gentoo.org> wrote:
> On 3/13/25 12:21 PM, or...@riseup.net wrote:
> > From: orbea <or...@riseup.net>
> >
> > When using slibtoolize it needs the /usr/share/slibtool/slibtool.m4
> > file to properly create the configure script. The current method of
> > using it is to set AT_SYS_M4DIR in make.conf, while this works for
> > most cases it does not work for app-crypt/tpm2-tss which uses
> > ACLOCAL_AMFLAGS with the '--install' argument in Makefile.am which
> > results in it trying to install .m4 files to /usr/share/slibtool.
> > This thankfully fails due to sandbox.
> >
> > To solve this problem the /usr/share/slibtool path can be directly
> > appended to "${T}"/aclocal/dirlist if the LIBTOOLIZE variable is
> > set to 'slibtoolize'.
> >
> > Closes: https://bugs.gentoo.org/950648
> > Signed-off-by: orbea <or...@riseup.net>
> > ---
> > eclass/autotools.eclass | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
> > index 1545b88bc4..023bedc8eb 100644
> > --- a/eclass/autotools.eclass
> > +++ b/eclass/autotools.eclass
> > @@ -382,6 +382,12 @@ eaclocal() {
> > ${BROOT}/usr/share/aclocal
> > ${ESYSROOT}/usr/share/aclocal
> > EOF
> > + if [ "${LIBTOOLIZE:-}" = 'slibtoolize' ]; then
> > + printf '%s\n' \
> > + "${BROOT}/usr/share/slibtool" \
> > + "${ESYSROOT}/usr/share/slibtool" \
> > + >> "${T}"/aclocal/dirlist
> > + fi
> > fi
> >
> > [[ ! -f aclocal.m4 || -n $(grep -e 'generated.*by aclocal'
> > aclocal.m4) ]] && \
>
>
> I had discussed this in IRC last week with Sam. My conclusion was:
>
> We end up running with
>
> aclocal -I ${AT_M4DIR} -I ${AT_SYS_M4DIR} ${ACLOCAL_AMFLAGS}
> --system-acdir="${T}"/aclocal
>
> We *should* be running with this instead:
>
>
> aclocal -I ${AT_M4DIR} ${ACLOCAL_AMFLAGS} -I ${AT_SYS_M4DIR}
> --system-acdir="${T}"/aclocal
The trivial change which does work for tpm2-tss would be to change it
to:
aclocal -I ${AT_M4DIR} ${ACLOCAL_AMFLAGS} --system-acdir="${T}"/aclocal
-I ${AT_SYS_M4DIR}
Changing it as you suggested I think would be significantly more
complicated and would require refactoring the eclass.
However I wonder if my patch still has merit since in the case of
slibtoolize it only needs to be set for aclocal and not all the other
tools that are executed during eautoreconf? Although including it
everywhere doesn't seem to cause any problems yet either.
>
>
> Slibtool is a symptom of an underlying problem which is that the
> eclass has broken ordering regardless.
>
>
