sebb wrote:
> Sorry, but: -1
> 
> There should be NOTICE files in all the archives (jar, zip etc).
> The NOTICE file (found in SVN) needs to refer to Xerox - see
> jcs-1.3\src\aspect\Trace.aj
> 
> No KEYS file to check the signatures - and could not find it in SVN.
> 
> Sourcefiles:
> There should probably be AL2.0 headers in the .aj files (apart from
> Trace.aj)
>
> -0 Other problems:
>
> Website:
> The Changes report refers to CVS - this should really be SVN
> The JCoverage report should really open in a new window, as is done
> for Javadocs etc.
> The Checkstyle report is in German, ideally it should be in English.

All complaints have been fixed. The new versions are online. I beg for
pardon again. I uploaded a copy of the KEYS file to both, the jar and
the dist directory for your convenience.

I'm not sure how to handle the Xerox copyright stuff. I included the
whole text inside the NOTICE file for now. Don't know if that is
appropriate.

Would you please be so kind as to review again and vote again.

Bye, Thomas.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to