+1 (binding)

Podling vote:

The podling vote on [email protected] is still open. No result mail.
Vote: https://lists.apache.org/thread/lbh81d6n98pgoo2xjfgo206k7stdvs3c
The thread has three +1 replies and no 0 or -1. Xuanwo and Hulk Lin marked
binding. tison did not. The call said the vote would remain open until at
least 28 October 2026 at 16:34:46 UTC. That time has passed. A result mail
has not. The artifacts named there are the ones in this vote. I am not
treating that tally as my own review.

Source archives:

Each checked with its .asc and .sha512:
apache-casbin-jcasbin-1.100.0-incubating-src.tar.gz
apache-casbin-jcasbin-1.100.0-incubating-src.zip

Both filenames contain incubating. SHA-512 matched. gpg --verify reported
Good signature from key id 96E22C88, the release manager key named in the
vote. The key is not certified with a trusted signature. That warning is
not a bad signature.

Both source archives contain the same 219 files. SHA-256 of every file
matched. Those 219 files also match git commit
38766ce5c270d53a83544886a204693e575b08fe. No extra files, no missing files,
no content differences.

License and headers:

LICENSE, NOTICE, and DISCLAIMER are present. Those three files inside each
staged jar match the source bytes. The license inventory searched Java,
Scala, Python, and Go. It found no non-ASF copyright lines. Its 18 "based
on" hits are English comments, not ports. The inventory checklist file is a
static template, not findings.

Apache RAT 0.18, launched with Java 17 and Maven 3.9.16 because the project
pom does not declare the plugin: Unapproved 0, Unknown 0, Standards 209,
Binaries 1. I invoked org.apache.rat:apache-rat-plugin:0.18:check. I did
not rely on pom excludes. The one binary mark is casbin-logo.png, an image,
not a compiled binary. A fresh extract of the source tar.gz contained no
.class, .jar, .so, .o, .a, .exe, or .dll files.

Build:

>From the extracted source archive, JDK 8, Maven 3.9.16. RELEASING.md is in
the tree, so the command was:
mvn -B -ntp clean verify -Papache-release -Drevision=1.100.0 -Dgpg.skip=true
CASBIN_CONFORMANCE_DIR was set to the conformance directory of
apache/casbin commit c35c93d29063b8bc3bc2ef30b09943d344a289f4.
Tests run: 345, Failures: 0, Errors: 0, Skipped: 0. BUILD SUCCESS.
That command also wrote jcasbin-1.100.0-sources.jar and
jcasbin-1.100.0-javadoc.jar under target/. verify includes package. The pom
binds maven-source-plugin (jar-no-fork) and maven-javadoc-plugin (jar) to
that phase, so those two jars are a normal result of the build. The
apache-release profile does not create them and does not suppress them. It
only sets the source-release assembly and checksum executions to phase
none, which skips the source-release tarball. The zero-skip test result is
from this command with CASBIN_CONFORMANCE_DIR set. I did not run the same
command without that variable.

Staged Maven files:

>From the repository named in the vote, each checked with its .asc and
.sha1. That repository publishes SHA-1, not SHA-512:
jcasbin-1.100.0.jar
jcasbin-1.100.0-sources.jar
jcasbin-1.100.0-javadoc.jar
jcasbin-1.100.0.pom
Good signature from key id 96E22C88. SHA-1 matched. Class files and source
files match the local release-profile build after CRLF normalization. The
main jar and the sources jar differ from the local build only by CRLF. The
javadoc jar has 242 raw entry differences. Two remain after CRLF
normalization: package-use.html used-by anchors differ, and Util.html
differs by one space of indentation. Those are generator differences, not
source differences.

Not in this commit:

PRs 539 and 540 are not in commit 38766ce5. I did not reproduce the cases
they describe. The PPMC deferred them to a later release. RC4 was cancelled
for authorization issues. The tagged commit is the PR 538 fix. I did not
reproduce the RC4 failure cases outside this test suite.

Build host:

Rocky Linux 9.8, x86_64, 16 vCPU, c7i.4xlarge, 100 GB gp3 root. The
filesystem reports 99G.
Login user: rocky.
Build JAVA_HOME: /usr/lib/jvm/java-1.8.0-openjdk (OpenJDK 1.8.0_504).
RAT launch JAVA_HOME: /usr/lib/jvm/java-17-openjdk (OpenJDK 17.0.20.1).
Already on the image. Not the default.
Maven: 3.9.16 at /home/rocky/opt/apache-maven-3.9.16, installed by the
jcasbin prepare step. The image Maven is 3.6.3, which BUILDING.md and RAT
0.18 reject.
Go: 1.26.10 at /opt/go/bin/go. Not used by this build.
AMI recipe:
https://github.com/edespino/cloudberry-image-factory/tree/main/vm-images/aws/cloudberry/build/rocky9

Version checks:

The built jars are jcasbin-1.100.0.jar, jcasbin-1.100.0-sources.jar, and
jcasbin-1.100.0-javadoc.jar. Those names match the release number and do
not say incubating. The source archive filenames include incubating. The
Maven version is the release number without incubating.

Not checked:

The cases described in PRs 539 and 540. The RC4 failure cases, outside the
release-profile test suite.

-- 
Ed Espino
Apache Cloudberry (Incubating)

cell: 925.389.4640 <(925)%20389-4640>

Reply via email to