+1 (binding) I checked (on the source distribution): - signature and checksum are good - incubating is in the name/version - LICENSE, NOTICE, DISCLAIMER are present and look good - No unexpected binary files (only casbin-logo.png) - All source files have ASF header - Build with JDK 8 / Maven 3.10.0 (mvn clean verify -Papache-release -Drevision=1.100.0 -Dgpg.skip=true): BUILD SUCCESS, 345 tests, 0 failures, 0 errors, 1 skipped (ConformanceTest, as CASBIN_CONFORMANCE_DIR was not set) - Staged jcasbin-1.100.0.jar and pom: good signatures; the jar contains only org.casbin.jcasbin classes plus LICENSE, NOTICE and DISCLAIMER
Not blocking this release, but I would like the podling to clarify the license of the io.github.aviatorscript:aviator:5.9.0 dependency. Aviator is not bundled in the source release or in the jar, but it is a required dependency (used by CoreEnforcer and the built-in functions): - AviatorScript (https://github.com/killme2008/aviatorscript) is licensed under the LGPL, Copyright Dennis Zhuang. In 2020, the author declined a request to move to the Apache License: https://github.com/killme2008/aviatorscript/issues/256 - On 2026-01-22, a copy was created at https://github.com/aviatorscript/aviatorscript, and the same day the license file and the source headers were changed from LGPL to Apache 2.0 (https://github.com/aviatorscript/aviatorscript/issues/5 and https://github.com/aviatorscript/aviatorscript/pull/6), keeping the "Copyright (C) 2010 dennis zhuang" line. The change was not made by the original author, and I could not find any statement from the copyright holders agreeing to it. - The published aviator-5.9.0-sources.jar still contains the original LGPL header in com/googlecode/aviator/AviatorEvaluatorInstance.java. - jCasbin switched to this artifact the next day: https://github.com/apache/casbin-jcasbin/pull/501 If the relicensing is valid, this is a regular Apache 2.0 dependency and there is no problem. If not, jCasbin would have a required (not optional) dependency on Category X code: https://www.apache.org/legal/resolved.html#optional Can the podling point to the agreement of Dennis Zhuang (and other significant contributors, if needed) to relicense AviatorScript under the Apache License 2.0? If that is not available, I suggest raising it on [email protected] and addressing it before the next release. Sorry if it has been discussed before, but I missed in my previous reviews :) Minor: the source tree builds as version 0.0.0 unless -Drevision=1.100.0 is passed. It would be nice if the source release carried its own version. Thanks! Regards JB On Mon, Oct 26, 2026 at 5:47 PM Yanrui Zhang <[email protected]> wrote: > Hi all, > > The Apache Casbin (Incubating) community requests IPMC approval to release > JCasbin 1.100.0 RC5. > > We are conducting this IPMC vote concurrently with the ongoing PPMC vote. > The dev vote has received three +1 votes from Xuanwo, tison and Hulk Lin, > all current PPMC and IPMC members, and no 0 or -1 votes so far. The dev > vote will remain open until at least 28 October 2026 at 16:34:46 UTC. > We will share the dev vote result after it closes. > > Dev vote: > https://lists.apache.org/thread/lbh81d6n98pgoo2xjfgo206k7stdvs3c > > Current dev votes and reviews: > Xuanwo (+1): > https://lists.apache.org/thread/vg4gyvvczdttdpb6y229dq0m00l8fzdm > tison (+1): > https://lists.apache.org/thread/m7j7t6x5o5m19qxfn524pjv4rldwpvtv > Hulk Lin (+1): > https://lists.apache.org/thread/09o67wmopfcmwx7chh343cksobh0qlnr > > RC5 includes PR #538 and its regression tests addressing the domain > isolation and conditional role restriction findings from the RC4 review. > The Java 8 runtime baseline and Javadoc generation remain unchanged. > > tison also voted +1 and noted follow-up work in PRs #539 and #540 that > can be considered for a later release. His review is linked above. > > Source candidate: > > https://dist.apache.org/repos/dist/dev/incubator/casbin/jcasbin-1.100.0-incubating-rc5/ > > Tag: > https://github.com/apache/casbin-jcasbin/tree/v1.100.0-rc5 > > Commit: 38766ce5c270d53a83544886a204693e575b08fe > > Maven staging repository: > https://repository.apache.org/content/repositories/orgapachecasbin-1006/ > > Coordinates: org.apache.casbin:jcasbin:1.100.0 > > KEYS: > https://downloads.apache.org/incubator/casbin/KEYS > > Signing fingerprint: 3D73A1589B87F65ACEB0B07683A465B996E22C88 > > Both source archives contain the same 219 reviewed files. Checks covered > SHA-512, signatures against official KEYS, RAT, source/artifact > correspondence > and legal files in all three JARs. The actual Java 8 release-profile build > passed all 345 tests without failures, errors or skips, including > conformance > testing with pinned external inputs. The staged main, sources and Javadoc > JARs, resolved POM and signatures were independently downloaded and matched > the verified signed build. Nexus1006 is closed, and the standard staging > URLs were independently reverified. > > This vote will remain open for at least 72 hours. > > [ ] +1 approve > [ ] 0 no opinion > [ ] -1 disapprove (please explain) > > Thanks, > Yanrui Zhang > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
