gradlew is useful but gradle installed on your build machine works just as well I wouldn't worry too much about not providing gradlew in source distributions. The Kafka/Iceberg gradlew file is fine and it's ok to include but Windows users can just install Gradle on their own machines.
On Tue, 2 Dec 2025 at 01:47, tison <[email protected]> wrote: > > Here is a solution to avoid bundling gradle.jar [1][2] in a source > distribution: like mvnw, download the binary if it is missing. > > [1] > https://github.com/apache/iceberg/blob/b35c7ec1b03e3897da68960cd556d635b2f5ae54/gradlew#L89-L91 > [2] > https://github.com/apache/kafka/blob/a7246ff13853d51c0005effbe4d277fc8c50e511/gradlew#L203-L234 > > They don't provide a version of gradlew.bat; instead, they delete it. > I hope Windows users will be fine since there is WSL now. > > Best, > tison. > > sebb <[email protected]> 于2025年12月2日周二 08:39写道： > > > > The gradle.jar is included in the source repo [1] > > > > That does not seem right. > > > > Sebb > > [1] > > https://github.com/apache/iggy/tree/4a9e215a4b6b1476daae8c4c3c34252b5162a240/foreign/java/gradle/wrapper > > > > On Mon, 1 Dec 2025 at 23:22, Justin Mclean <[email protected]> wrote: > > > > > > Hi, > > > > > > Having compiled code in a source release is not allowed by ASF policy > > > [1], same for the issue with the LICENSE file [2]. I would suggest > > > creating another RC. > > > > > > Kind Regards, > > > Justin > > > > > > 1. https://www.apache.org/legal/release-policy.html#source-packages > > > 2. https://www.apache.org/legal/release-policy.html#license-file > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
