Hi, There’s no issue with the file headers, other than it just hard to review as there is a lot of files without headers. On solution is to perhaps put all the 3rd party code into a folder called “3rdparty” so it’s clearer what is ASF code and what is not?
Re license information you need to list any 3rd party code bundled in the release that is licensed under the Apache license in the LICENSE file, not in the NOTICE file. There is no need to add a second copy of the apache license text to the LICENSE file. Typically you would mention the software name, version, copyright owner and location where it came from. Things get added to notice files for a number of reasons and each is treated slightly differently, how you handle a SGA is different to how you handle a ALv2 licensed bit of 3rd party code which has a NOTICE file. For the how to your case please see [1]. In this case it you would just copy and past the content of that notice file into yours. The terminology "This product includes software from...” is usually used with a software grant and where the copyright headers have been replaced and then relocated to the NOTICE file. It's a good idea to use a WIP disclaimer while these details are being sorted, if you had I would have voted +1 on this release. Kind Regards, Justin 1. https://infra.apache.org/licensing-howto.html#alv2-dep --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
