You know, I want to know clearly what we need to put because we already iterate four times, and if you tell us what we need to do and add, it will be faster and more efficient.
The license issue came again over the same files, and this is the second time the release got rejected by the same problem but with a different header. In the case of [1], use Apache royale as an example, then you can find the header of file swfobject [2]. We use the swfobject file header as a base for the profile-db module, where all of the files have the header [4]. So that follows the example file and has the elements that Apache Rat needs [5] to label as a valid header, we need to add that because the original code does not have headers. So if that is the incorrect way, could you give an example to follow or tell us what we are doing wrong. About "License information needs to go in the LICENSE file." in [6] is said ""ALv2 applies uniformly to all files, there is no need to modify LICENSE""; and the code of profile-db is under Apache License 2.0[7]. Then what is the modification that we need to add, or am I misreading this? Concerning respect to the NOTICE, we follow [8] because it said, "Aside from Apache-licensed dependencies which supply NOTICE files of their own, it is uncommon for a dependency to require additions to NOTICE". Also, we follow the example [1] where the relevant elements are creators, location of the code and copywriting. However, if we follow the quote of [8], do we need to specify in the notice because the original code is Apache License [7]?; nevertheless, we add the [9] following the example [1] having the same elements. The actual code follows the adding license [10] but does not give the grant to ASF. Then what exactly do we need to add, or am I misreading something? [1] *https://infra.apache.org/licensing-howto.html#example-notice <https://infra.apache.org/licensing-howto.html#example-notice>* [2] https://github.com/apache/royale-asjs/blob/develop/examples/mxroyale/tourdeflexmodules/src/swfobject.js#L1-L4 [4] https://github.com/apache/incubator-wayang/blob/main/wayang-commons/wayang-utils-profile-db/src/main/java/org/apache/wayang/commons/util/profiledb/ProfileDB.java#L1-L7 [5] https://github.com/apache/creadur-rat/blob/master/apache-rat-core/src/main/java/org/apache/rat/analysis/license/ApacheSoftwareLicense20.java [6] https://infra.apache.org/licensing-howto.html#alv2-dep [7] https://github.com/sekruse/profiledb-java/blob/master/LICENSE [8] https://infra.apache.org/licensing-howto.html#mod-notice [9] https://github.com/apache/incubator-wayang/blob/main/NOTICE#L8-L12 [10] https://www.apache.org/licenses/LICENSE-2.0#apply On Wed, Dec 1, 2021 at 5:28 AM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > Sorry but it’s -1 (binding) from me. You might want to consider using the > work in progress disclaimer. > > I checked: > - incubator in name > - signatures and hashes are fine > - LICENSE is missing info on [1] and about a dozen other files. License > information needs to go in the LICENSE file. [3] > - NOTICE should really include what is at [2] what there probably covers > it but is a little unusual as reads like the software was given to the ASF > in a software grant. > - All files have ASF headers > - Can compile from source > > Kind Regards, > Justin > > > 1. > ./wayang-commons/wayang-utils-profile-db/src/test/java/org/apache/wayang/commons/util/profiledb/measurement/TestTimeMeasurement.java > 2. https://github.com/sekruse/profiledb-java/blob/master/NOTICE > 3. https://infra.apache.org/licensing-howto.html > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
