HI, -1 (binding) because of hash issue - but this is easily fixed without stopping the vote and there’s no need for a revote. Once change I check and change my vote to +1
I checked: - incubating in name - signature is fine (although it would be good to sigh with an apache email address) - hash needs to be sha256 or sha512 [1] - DISCLAIMER exits - LICENSE is OKish - NOTICE year is out of date (2016!) Please fix. - No unexpected binary files - Can compile from source License mentions "This product includes software developed at Yahoo! Inc.” but doesn’t say how that is licensed I think this needs to be in NOTICE not LICENSE as teh copyright headers have been relocated right? It also unclear where the code for MOA is bundled. Thanks, Justin 1. https://infra.apache.org/release-distribution-policy.html --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
