+1 (binding) with some caveats.

I checked:
* Incubating in name
* DISCLAIMER exists
* LICENSE and NOTICE okay (copyright end year in NOTICE needs a bump I
would suspect)
* Signatures okay
* Checksums okay

My understanding is that the KEYS file for your project is expected in:
  https://dist.apache.org/repos/dist/release/incubator/samoa/KEYS (or via
the external URL https://downloads.apache.org/incubator/samoa/KEYS)
It would normally contain the keys for all release managers. I believe you
can just copy your file there now - please do.

Rat indicates that the following files need headers or an exclusion (if
generated or header can't be there for some technical reason):
  sign.sh
  DEPENDENCIES
  CONTRIBUTING.md
  checkstyle/header.regexp
  bin/samza-kryo
  src/main/resources/kafka.avsc (samoa-api)
  src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem
(samoa-api)
[None of these seem like critical IP to me, so not worth cancelling but
this should be easy to fix up for next release.]

The following test failed on Ubuntu and WSL:
  Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.384 sec
<<< FAILURE! - in
org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest

testStartSendingEvents(org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest)
 Time elapsed: 0.31 sec  <<< ERROR!
  java.lang.IllegalStateException: Missing invocation to mocked type at
this point; please make sure there is an associated mock field or mock
parameter in scope
  at
org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest$4.<init>(SimpleEntranceProcessingItemTest.java:158)...

Additional tests failed under Windows, e.g.:
  Tests run: 10, Failures: 0, Errors: 10, Skipped: 0, Time elapsed: 8.097
sec <<< FAILURE! - in org.apache.samoa.streams.fs.HDFSFileStreamSourceTest

testGetNextInputStream(org.apache.samoa.streams.fs.HDFSFileStreamSourceTest)
 Time elapsed: 6.661 sec  <<< ERROR!
  java.lang.UnsatisfiedLinkError:
org.apache.hadoop.io.nativeio.NativeIO$Windows.access0(Ljava/lang/String;I)Z...

Attempting to test under Windows with JDK 11.0.5 gave:
  [ERROR] Caused by: java.lang.IllegalStateException: JMockit requires a
Java 6+ VM
  [ERROR]         at
mockit.internal.startup.AgentInitialization.loadAgentFromLocalJarFile(AgentInitialization.java:25)
[I am assuming there is something I don't have set up correctly in my
environment but would be good for you to list recommended JDK
versions/platforms in your vote email (and release email) if there are
restrictions, or point to some doco where such info is available]

I could build from source using `mvn -Dmaven.test.skip=true package` and
was then able to run the classifiers.ensemble.Bagging example from the
project home page.
[After printing out what looked like the results, bin/samoa didn't return
to the command prompt. I didn't know if that is expected behavior.]

Cheers, Paul.



On Mon, Mar 16, 2020 at 7:40 AM Corey Sterling <coreytsterl...@gmail.com>
wrote:

> Hi all,
>
> The SAMOA community has voted to promote a release candidate to a
> full-release.
>
> The vote thread can be found at:
>
> https://lists.apache.org/thread.html/r9ee34c67da99269915485635ae9c86e158fb9e149727e699d3990e23%40%3Cdev.samoa.apache.org%3E
>
> and the result thread at:
>
> https://lists.apache.org/thread.html/r066a4c6334e155887f6ab199fb9f52e0b7798a9a1940cae69a29671d%40%3Cdev.samoa.apache.org%3E
>
> We now invite the general incubator community to vote on releasing the same
> release candidate as Apache SAMOA (incubating) version 0.5.0.
>
> Release candidate 2 was skipped as during it's creation the Github mirror
> of the branch became out-of-sync with the Apache source repository.
>
> This release will be the third release for SAMOA in the incubator.
>
> -------------------------------------------------------------
> The commit to be voted on is in the branch "releases/0.5.0-incubating-RC3"
> (commit 9fe3b5582b7c697a00151902bd7e945aaf07506f):
> https://git-wip-us.apache.org/repos/asf?p=incubator-samoa
> .git;a=commit;h=9fe3b5582b7c697a00151902bd7e945aaf07506f
>
> Tag v0.5.0-incubating:
> https://git-wip-us.apache.org/repos/asf?p=incubator-samoa
> .git;a=commit;h=856a16920f7c19f94c43c3cdd287a86f52087c15
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/csterling
>
> The staging repository for this release can be found at:
>
> https://repository.apache.org/content/repositories/staging/org/apache/samoa/
> samoa/0.5.0-incubating/
> <https://repository.apache.org/content/repositories/staging/org/apache/samoa/samoa/0.5.0-incubating/>
>
> The developer's version artifacts:
>
> https://dist.apache.org/repos/dist/dev/incubator/samoa/0.5.0-incubating-rc3/
>
> -------------------------------------------------------------
>
> Please vote on releasing this package as Apache SAMOA 0.5.0 (incubating).
>
> [ ] +1 Release this package as Apache SAMOA 0.5.0 (incubating)
> [ ] -1 Do not release this package because ...
>
> Cheers,
>
> Corey.
>

Reply via email to