FWIW, some build and test processes have a "generate-sources" and/or "generate-test-sources" step. Have you considered having a step in your test processes copy the source test files into a temporary folder and remove the headers as part of that step? Then you may not need to change the test harness and expected result set.
HTH, -Alex On 1/23/18, 5:46 AM, "Geertjan Wielenga" <geertjan.wiele...@googlemail.com> wrote: >OK, makes sense, thanks for these insights and ideas. > >Gj > >On Tue, Jan 23, 2018 at 2:40 PM, Bertrand Delacretaz ><bdelacre...@codeconsult.ch> wrote: >> Hi, >> >> On Tue, Jan 23, 2018 at 2:35 PM, Geertjan Wielenga >> <geertjan.wiele...@googlemail.com> wrote: >> >>>... >>> >>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. >>>com%2Fapache%2Fincubator-netbeans%2Fblob%2Fmaster%2Fnbbuild%2Fbuild.xml& >>>data=02%7C01%7Caharui%40adobe.com%7C0a91dd1e925e467c4bed08d56267bfbc%7Cf >>>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636523120091967780&sdata=flP%2 >>>BmQUSLXLED3puYUrZzALhDD3adb%2F%2BSkgekR07mOQ%3D&reserved=0 >>> This is what line 2105 says: >>> <exclude name="*/test/unit/data/**" /> <!--would cause tests to >>>fail--> ... >> >> Maybe grouping those exclusions by families would make it easier for >> reviewers to understand them: first the ones which are not creative, >> then those where a header would cause tests to fail etc. >> >>> ...You're saying the comment isn't needed in the README... >> >> What I'm saying is that it shouldn't be duplicated - have the README >> point to that build.xml file,or as discussed a file that just has RAT >> exclusions, and add the comments next to the exclusions, pointing to >> apache.org docs where useful. >> >>> ...can NETBEANS-306 be closed as resolved?... >> >> I suggest grouping the exclusions that fall in that family and adding >> a pointer to the Apache docs that mention that the header is not >> required if it causes tests to fail. >> >> You then get links from README -> commented RAT exclusions -> Apache >> documentation which provide a clear justification. >> >> -Bertrand >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> > >--------------------------------------------------------------------- >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >For additional commands, e-mail: general-h...@incubator.apache.org >
