Thanks a lot for a thorough review! Will take some time to go through that
and fix, but a few questions:
On Tue, Jan 23, 2018 at 5:20 AM, Justin Mclean <jus...@classsoftware.com>
wrote:
> Hi,
>
> I did this fairly quickly so may of made a mistake or two and may of
> missed something. A number of issues here are due to upstream projects
> putting too much in NOTICE or not including a NOTICE file in the jar :-(
> But it also looked like you missing a couple of things from LICENSE as well
> and have a few thing listed under the wrong license. I think you may need
> someone to go though that list and double check.
>
> Netbeans jars are missing LICENSE and NOTICE file in META_INF. Note that
> this may vary on a jar by jar basis.
>
I guess I originally misunderstood the requirements here - I though that
these only need to be in the top-level of a release (we are not releasing
the jars separatelly). Should be fairly easy to add those to jars the
NetBeans build system produces.
[snip]
./ide/modules/org-openidex-util.jar
> - CDDL licensed missing in LICENSE
>
Hm, this should be under Apache 2.0 - this is built from "o.openidex.util"
from the source bundle. Is there something we need to fix so it does not
appear to be under CDDL?
[snip]
> platform/modules/ext/org.eclipse.osgi_3.9.1.v20140110-1610.jar
> - I’m not sure if the OSGi license is compatible with the Apache one. It’s
> not listed in Category A/B/X you may need to ask on legal discuss. It may
> be under EPL but not 100% sure.
>
Apache Felix is using those as well, I think?
[snip]
> ./platform/modules/net-java-html-boot-fx.jar
> ./platform/modules/net-java-html-boot-script.jar
> ./platform/modules/net-java-html-boot.jar
> ./platform/modules/net-java-html-geo.jar
> ./platform/modules/net-java-html-sound.jar
> ./platform/modules/net-java-html.jar
> - have NOTICE files that would effect the NOTICE file
> - a couple have DISCLAIMER is that’s right?
>
It is part of the NetBeans incubator project, so I believe it is right.
> - are the copyright lines in NOTICE correct here?
>
I don't know, it has been released this way.
[snip]
> ./platform/modules/org-openide-compat.jar
> ./platform/modules/org-openide-dialogs.jar
> (and a few others similarly named)
> - are missing from LICENSE
>
Ah, I guess the naming may be confusing here - I believe these are standard
NetBeans artifacts, for certain core stuff NetBeans is using "org.openide"
package (and module name). Built from openide.compat and openide.dialogs in
the source bundle, respectively. Is there something we can do to reduce
confusion?
Thanks,
Jan
>
> Thanks,
> Justin
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
