In many/most cases, the issues picked up by Justin are issues that are not visible if our rat exclusions are taken into account. Now, of course, what we can do is discuss those rat exclusions. However, a starting point would be for Justin or anyone else here to use those rat exclusions when running rat, as a starting point. Then we’ll all have the same results and can start discussions from the same basis.
Gj On Sunday, January 21, 2018, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Yes, we excluded test/*/data directories via rat exclusions on the basis > that files within them are test data and hence can be excluded. There is no > test code here. At worst, as pointed out below, there’s pseudo code. > > Gj > > On Saturday, January 20, 2018, Jan Lahoda <lah...@gmail.com> wrote: > >> On Sat, Jan 20, 2018 at 2:14 PM, Justin Mclean <justinmcl...@me.com> >> wrote: >> >> > Hi, >> > >> > > Could please the FAQ be updated with exact requirements (or the point >> > > removed), to avoid further confusion? >> > >> > It [1] seems clear to me i.e. there’s an exception for test data but not >> > test code. >> > >> >> Yes. I guess I wonder about which specific files we are talking here. If >> it >> is e.g.: >> refactoring.java/test/qa-functional/data/goldenfiles/ >> org/netbeans/modules/test/refactoring/MoveTest/testMoveClass.pass >> or: >> refactoring.java/test/qa-functional/data/projects/Refactorin >> gTest/src/introduceParameter/Class_A_A.java >> or: >> java.hints/test/unit/data/javahints/AbstractError1.java >> >> then these are test data (they are in test/*/data directories), not test >> code. They are a (semi) Java source code, as the Java related features run >> on "Java" source code, so that's what we need for testing. >> >> Jan >> >> >> > >> > Thanks, >> > Justin >> > >> > 1. https://www.apache.org/legal/src-headers.html#faq-exceptions >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > For additional commands, e-mail: general-h...@incubator.apache.org >> > >> > >> >
