Justin, I haven't gone through the full release yet, but wanted to run this by you.
On Sat, Jan 20, 2018 at 7:54 AM Justin Mclean <justinmcl...@me.com> wrote: > Hi, > > > Since two of our mentors gave a +1 in the PPMC vote, I’m interested in > > their take on your review too. Just curious, that’s all, how they > evaluate > > your points. > > Sure I would also be interested in what they have to say and I would be > wiling to change my vote if they can convince me to do so / provide reasons > for why the issues I brought up are not serious issues and can be fixed in > a later release. > > I see there's multiple issues in here, but do you agree that files like [1] are dual licensed EPLv1 and EDLv1 (BSD-3-Clause) so can be included? [1]: https://github.com/apache/incubator-netbeans/blob/master/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_2_0.xsd > > Also note that the link to the PPMC vote thread provides a > > link to the Ant Rat results, not sure why you’re getting different > results. > > It may be (and I’ve not checked) that the rat exclusions you have (if you > have any) been set a little too wide. I run rat manually over the entire > source release as that tends to pick up a few things that sometimes may be > missed. > > Thanks, > Justin
