Thank you Justin for the detailed analysis. On Fri, Aug 4, 2017 at 5:26 PM Justin Mclean <jus...@classsoftware.com> wrote:
> One minor thing I found is that several files [2][3][4][5] have double > ASF headers and incorrectly include an ASF copyright line. > Thanks for catching these. I've created a pull-request to fix it: https://github.com/apache/incubator-pulsar/pull/653 > BTW the other bundled ALv2 license software is missing a NOTICE file [1] > so there no need to add anything to your notice or license for that. > > The binary NOTICE file however needs some work: > - Notice file lists copyright owners when it doesn’t need to > Sure, we'll remove all the "copyright only" mentions in the NOTICE files and only leave portion that have additional "notices". > - Notice file list dependancies which while useful shouldn’t be in NOTICE > (although that may of been copied from Netty?) > Yes, we have included the NOTICE file as it comes from Netty [1], minus repeating the ALv2 license text. I believe most of those dependencies are actually bundled inside the Netty jar and thus they are not listed elsewhere as transitive dependencies for Pulsar. Does that make any difference in this context? What would be the recommended way to handle this? 1. https://github.com/netty/netty/blob/4.0/NOTICE.txt Thank you, Matteo -- Matteo Merli <mme...@apache.org>
