Hi, +1 binding
I checked: - incubating in name - signatures and hashes correct - DISCLAIMER exists - LICENSE and NOTICE good - No unexpected binary files in source release - All source files have ASF headers where needed - Can compile from source One minor thing I found is that several files [2][3][4][5] have double ASF headers and incorrectly include an ASF copyright line. BTW the other bundled ALv2 license software is missing a NOTICE file [1] so there no need to add anything to your notice or license for that. The binary NOTICE file however needs some work: - Notice file lists copyright owners when it doesn’t need to - Notice file list dependancies which while useful shouldn’t be in NOTICE (although that may of been copied from Netty?) Thanks Justin 1. https://github.com/trevorr/circe 2. managed-ledger/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java 3. managed-ledger/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java 4. pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/utils/IOUtils.java 5. pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/LocalBookkeeperEnsemble.java --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
