Kevin, Thanks for the comments. Just want to clarify on your points on LICENSE/NOTICE. Our LICENSE/NOTICE covers all jars included in the source, not those pulled in during building. We had a long discussion during our 1st release and in the end, we have reached the conclusion that we don't have to document LICENSE/NOTICE for jars not included in the source (since we are just doing a source release). Please correct me if you think this is blocking the release. We have to include a small number of jars in the source because there is no easy way to pull them in automatically.
Thanks, Jun On Mon, Jun 18, 2012 at 1:53 PM, Kevan Miller <kevan.mil...@gmail.com>wrote: > Things that I've noted: > > I don't see a checksum for your release in > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ -- > your release manager will need to generate a checksum for the release. > > It would be nice if your archive extracted into an > apache-kafka-0.7.1-incubating directory (or similar name rather than .), > but that's minor. > > I see the following binary files in your source distribution: > > ./clients/csharp/lib/nunit/2.5.9/nunit.framework.dll > ./contrib/hadoop-consumer/lib/pig-0.8.0-core.jar > ./contrib/hadoop-consumer/lib/piggybank.jar > ./contrib/hadoop-producer/lib/pig-0.8.0-core.jar > ./contrib/hadoop-producer/lib/piggybank.jar > ./lib/sbt-launch.jar > > If I understand correctly, this does not meet a definition of an open > source release (which is what an apache release is…). It looks like this is > how your last release was packaged, also… I don't know if this is a > blocking issue (for an incubator release), but I think you need to work on > resolving this (i.e. remove binaries from your source)… > > IIUC, your LICENSE/NOTICE files are documenting your "source" (including > the above jars). Do you document the LICENSE/NOTICE of your binaries? I > built kafka and see that a number jars are pulled in… I have no idea what > the LICENSING for these artifacts is… and whether or not they conform to > ASF standards (I did not review them all). Your project needs to document > them. > > FYI, I couldn't figure out from the documentation how to start a server > after I built kafka. > > --kevan > > On Jun 18, 2012, at 1:14 PM, Jun Rao wrote: > > > Any other voters? > > > > Thanks, > > > > Jun > > > > On Thu, Jun 14, 2012 at 11:42 AM, Joe Stein <crypt...@gmail.com> wrote: > > > >> Hello, > >> > >> This is the second candidate for the second incubator release for Apache > >> Kafka, version 0.7.1-incubating. > >> > >> This release fixes the following issues > >> > >> > http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/RELEASE-NOTES.html > >> > >> RC2 fixes the issue identified in RC1 => > >> https://issues.apache.org/jira/browse/KAFKA-365 change copyright in > NOTICE > >> to 2012 > >> > >> *** Please download, test and vote by Monday June, 18th, 12pm PDT > >> > >> Release artifacts: > >> http://people.apache.org/~joestein/kafka-0.7.1-incubating-candidate-2/ > >> > >> The tag to be voted upon (off the 0.7.1 branch): > >> > >> > https://svn.apache.org/repos/asf/incubator/kafka/tags/kafka-0.7.1-incubating-candidate-2 > >> > >> Kafka's KEYS file containing PGP keys we use to sign the release: > >> http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS > >> > >> /* > >> Joe Stein > >> http://www.linkedin.com/in/charmalloc > >> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop> > >> */ > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
