On Tue, 2009-09-08 at 22:28 +0100, sebb wrote: > Does the release actually *include* JUnit, or is that only used for > testing? If so, then it should not be the in the NOTICE file, nor in > the binary release.
We have a source and binary distribution with the same NOTICE and LICENSE texts in both artifacts. While we don't want/need to ship the junit jar in the binary distribution (see CASSANDRA-417), shipping it in the source artifact is intentional. > Is ANTLR actually needed at run-time, or is it only needed for > building the code? It's only used to build. > I'm not sure whether it needs to be mentioned in NOTICE if it is only > used at build-time. I had thought it was needed when redistributing code with the terms that require it (and as far as I know, that's only Apache License 2.0). I was told on this list (repeatedly), that I was wrong. Now I'm just confused. Again. > It should not be in the binary release if it's not needed at run-time. Agreed (CASSANDRA-417), but again, shipping a copy in the source artifact is intentional, (hence the entries in NOTICE and LICENSE). > The NOTICE file mentions SLF4J, which AIUI is a logging abstraction - > does the binary release include a logging implementation? If so, it > will need to be documented in the LICENSE and NOTICE. We use log4j for logging, but we require/ship thrift which in turn requires slf4j. > > It would be great if we could get these reviewed ahead of time so > that > > any feedback could be incorporated before the next release vote. > > It's not possible to be definitive about the files without knowing > what libraries are actually going to be included in the binary > release. There haven't been any changes since the last review, (see https://svn.apache.org/repos/asf/incubator/cassandra/trunk/lib). Thanks for taking the time to look at this. -- Eric Evans eev...@rackspace.com --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
