On Sun, Dec 28, 2008 at 10:49:45PM -0500, DJ Delorie wrote:
> 
> Re: sourceforge bug # 1890743

First, please don't say "dicer" when you don't mean "dicer".  The
polygon dicer is the code that cuts a polygon with holes (such as any
typical plane) up into sub-parts which have no holes.  These are used
to render to certain devices.

> The underlying code checks the polygon clearance of each pad that's in
> a polygon.  If it's too little, it complains.

Your patch is not acceptable.  You should never modify data structures
like that.  If you want to pass additional bloat, pass it as an argument.
The thickness is reflected in other parts of the data structure (such as
the bounding box) so you are making the pad inconsistent anyway, which
could lead to problems if someone later optimized IsLineInPolygon.

It already looks like there's a crappy way to do this.  The Bloat added
in IsPadInPolygon is the static one in find.c which is manipulated by
the DRC.  It seems to be -PCB->Shrink.  Modifying that might be what you
want, but it looks like it's already trying to cover your case...  Maybe
Bloat/fBloat is set wrong for that series of tests.

-- 
Ben Jackson AD7GD
<[email protected]>
http://www.ben.com/


_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev

Reply via email to