Hi Jürgen, The commit you're referring to, doesn't seem contain the handling of the bExactMatch parameter at the driver. At the moment I consider this a bit redundant if calling OGRLayer::FindFieldIndex with bExactMatch = TRUE does the same as OGRLayer::GetFieldIndex. In this regard I'd be in favour of using the same signature for both functions. In ogr2ogr we could then do something like:
int iDstField = bExactFieldNameMatch? poDstLayer->GetFieldIndex(poSrcFieldDefn->GetNameRef()) : poDstLayer->FindFieldIndex(poSrcFieldDefn->GetNameRef()); Best regards, Tamas 2013/10/6 Jürgen E. <j...@norbit.de> > Hi Tamas, > > On Sun, 06. Oct 2013 at 20:05:18 +0200, Tamas Szekeres wrote: > > Looks like a good proposal. > > The only thing I'm uncertain about whether the driver should do > something > > different when calling OGRLayer::FindFieldIndex with bExactMatch = > TRUE > > than when calling OGRLayer::GetFieldIndex? I don't see the driver > > implementation in the pull request which would probably make that > thing > > more trivial to understand. > > The pull request only has an implementation for the OCI driver: > > https://github.com/jef-n/gdal/commit/66723a4bb75c5aa1afd309420bc563e1a48b074b#diff-156f2c76948ed9a6134f385f35e83165R495 > > > Jürgen > > -- > Jürgen E. Fischer norBIT GmbH Tel. +49-4931-918175-31 > Dipl.-Inf. (FH) Rheinstraße 13 Fax. +49-4931-918175-50 > Software Engineer D-26506 Norden > http://www.norbit.de > QGIS PSC member (RM) IRC: jef on FreeNode > > -- > norBIT Gesellschaft fuer Unternehmensberatung und Informationssysteme mbH > Rheinstrasse 13, 26506 Norden > GF: Jelto Buurman, HR: Amtsgericht Emden, HRB 5502 > > _______________________________________________ > gdal-dev mailing list > gdal-dev@lists.osgeo.org > http://lists.osgeo.org/mailman/listinfo/gdal-dev >
_______________________________________________ gdal-dev mailing list gdal-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/gdal-dev
