On Wed, Dec 17, 2014 at 04:14:00PM -0500, Jason Merrill wrote:
> On 12/05/2014 03:28 PM, Jakub Jelinek wrote:
> >3) there is no __has_attribute__ middle-end secondary macro,
> > when it is a built-in macro, it works fine in #ifdef too
>
> I'm not sure what the rationale for the secondary macro was. Ed?
Can't speak for Ed of course, my understanding for the secondary
macro was that one should be able to use #ifdef __has_attribute
and the current trunk's __has_attribute__ is not a macro, just special
processing of a token in #if directives, similar to say defined(...),
so it couldn't be used easily in #ifdef (nor redefined etc.).
> >-cb_has_attribute (cpp_reader *pfile)
> >+c_common_has_attribute (cpp_reader *pfile)
>
> Let's not change the name; it's still a lexer callback rather than a
> function to be called by C-family front ends.
Ok.
> OK with that change if Ed doesn't object in the next couple of days.
Will wait.
Jakub
