On Thu, Dec 4, 2014 at 1:04 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Thu, Dec 04, 2014 at 04:00:27AM -0800, H.J. Lu wrote: >> >> Can you add a few testcases? >> > >> > Isn't it already covered by gcc.dg/torture/vshuf* ? >> > >> >> I didn't see them fail on my machines today. > > Those are executable testcases, those better should not fail. > The patch just improved code generation and the testcases test > if the improved code generation works well. > Did you mean some scan-assembler test that verifies the better code > generation? Guess it is possible, though fragile.
I think that existing executable testcases adequately cover the functionality of the patch. The patch is OK. Thanks, Uros.
