On 12/03/14 11:48, David Malcolm wrote:
On Mon, 2014-12-01 at 19:31 -0500, Ulrich Drepper wrote:
I think the jit patches introduced a problem when you rebuild within a
directory that contains an old build (i.e., no brand new build
directory). The gcc/Makefile creates a symlink for xgcc with the full
driver name without first removing the symlink.
I think you're right. Sorry about this. I've been occasionally seeing
this. It appears to be an issue if rebuilding, having run the jit
testsuite, having touched something that affects ./xgcc.
The right procedure
(gathered from other Makefiles) seems to be to just use rm first. This
is what the patch below does.
In addition I took the liberty of changing the Makefile to us $(LN_S)
instead on $(LN) -s.
OK?
I don't know if I'm qualified to review this [1], but the patch looks
good to me. I've tested it at this end.
Thanks
Dave
[1] fwiw FULL_DRIVER_NAME is AFAIK only used by the jit, and I'm jit
maintainer.
The fact that it's only used for the JIT puts this patch into your
domain as far as I'm concerned.
Uli, go ahead and check this in. Thanks,
Jeff
