On Mon, Nov 17, 2014 at 5:06 AM, Hale Wang <hale.w...@arm.com> wrote:
> Hi,
>
> Refer to the previous small multiply patch (r217175).
>
> The conditions in the small multiply test cases are not restrictive enough.
> If forcing the march=armv4t/armv5t, these cases will fail.
> These cases can be used only if we defined "
> -mcpu=cortex-m0/m1/m0plus.small-multiply ".
>
> This patch is used to fix this issue.
>
> These cases will be skipped if we don't define
> "-mcpu=cortex-m0/m1/m0plus.small-multiply". So no influence to other
> targets.
>
> Build gcc passed. Is it OK for trunk?

Ok , thanks.

Ramana
>
> Thanks and Best Regards,
> Hale Wang
>
> gcc/testsuite/ChangeLog:
>
> 2014-11-13  Hale Wang  <hale.w...@arm.com>
>
>         * gcc.target/arm/small-multiply-m0-1.c: Only apply when
>         " -mcpu=cortex-m0/m1/m0plus.small-multiply ".
>         * gcc.target/arm/small-multiply-m0-2.c: Likewise.
>         * gcc.target/arm/small-multiply-m0-3.c: Likewise.
>         * gcc.target/arm/small-multiply-m0plus-1.c: Likewise.
>         * gcc.target/arm/small-multiply-m0plus-2.c: Likewise.
>         * gcc.target/arm/small-multiply-m0plus-3.c: Likewise.
>         * gcc.target/arm/small-multiply-m1-1.c: Likewise.
>         * gcc.target/arm/small-multiply-m1-2.c: Likewise.
>         * gcc.target/arm/small-multiply-m1-3.c: Likewise.
> ========================================================
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m0-1.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m0-1.c
> index 77ec603..49132e3 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m0-1.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m0-1.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m0.small-multiply" { arm*-*-* }
> { "-mcpu=*" } { "-mcpu=cortex-m0.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m0.small-multiply" { arm*-*-* }
> { "*" } { "-mcpu=cortex-m0.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m0.small-multiply -mthumb -O2" } */
>
>  int
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m0-2.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m0-2.c
> index c89b3ba..7f1bf7b 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m0-2.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m0-2.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m0.small-multiply" { arm*-*-* }
> { "-mcpu=*" } { "-mcpu=cortex-m0.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m0.small-multiply" { arm*-*-* }
> { "*" } { "-mcpu=cortex-m0.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m0.small-multiply -mthumb -Os" } */
>
>  int
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m0-3.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m0-3.c
> index b2df109..aca39d7 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m0-3.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m0-3.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m0.small-multiply" { arm*-*-* }
> { "-mcpu=*" } { "-mcpu=cortex-m0.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m0.small-multiply" { arm*-*-* }
> { "*" } { "-mcpu=cortex-m0.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m0.small-multiply -mthumb -Os" } */
>
>  int
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-1.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-1.c
> index 08a450b..12e8839 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-1.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-1.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m0plus.small-multiply" {
> arm*-*-* } { "-mcpu=*" } { "-mcpu=cortex-m0plus.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m0plus.small-multiply" {
> arm*-*-* } { "*" } { "-mcpu=cortex-m0plus.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m0plus.small-multiply -mthumb -O2" } */
>
>  int
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-2.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-2.c
> index 17b52d3..3e3c9b2 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-2.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-2.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m0plus.small-multiply" {
> arm*-*-* } { "-mcpu=*" } { "-mcpu=cortex-m0plus.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m0plus.small-multiply" {
> arm*-*-* } { "*" } { "-mcpu=cortex-m0plus.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m0plus.small-multiply -mthumb -Os" } */
>
>  int
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-3.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-3.c
> index af69c75..75e3432 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-3.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m0plus-3.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m0plus.small-multiply" {
> arm*-*-* } { "-mcpu=*" } { "-mcpu=cortex-m0plus.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m0plus.small-multiply" {
> arm*-*-* } { "*" } { "-mcpu=cortex-m0plus.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m0plus.small-multiply -mthumb -Os" } */
>
>  int
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m1-1.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m1-1.c
> index d265aaf..fbe90cc 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m1-1.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m1-1.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m1.small-multiply" { arm*-*-* }
> { "-mcpu=*" } { "-mcpu=cortex-m1.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m1.small-multiply" { arm*-*-* }
> { "*" } { "-mcpu=cortex-m1.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m1.small-multiply -mthumb -O2" } */
>
>  int
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m1-2.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m1-2.c
> index c50891c..6fca405 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m1-2.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m1-2.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m1.small-multiply" { arm*-*-* }
> { "-mcpu=*" } { "-mcpu=cortex-m1.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m1.small-multiply" { arm*-*-* }
> { "*" } { "-mcpu=cortex-m1.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m1.small-multiply -mthumb -Os" } */
>
>  int
> diff --git a/gcc/testsuite/gcc.target/arm/small-multiply-m1-3.c
> b/gcc/testsuite/gcc.target/arm/small-multiply-m1-3.c
> index 1da21a6..bc732c3 100644
> --- a/gcc/testsuite/gcc.target/arm/small-multiply-m1-3.c
> +++ b/gcc/testsuite/gcc.target/arm/small-multiply-m1-3.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> -/* { dg-skip-if "Test is specific to cortex-m1.small-multiply" { arm*-*-* }
> { "-mcpu=*" } { "-mcpu=cortex-m1.small-multiply" } } */
> +/* { dg-skip-if "Test is specific to cortex-m1.small-multiply" { arm*-*-* }
> { "*" } { "-mcpu=cortex-m1.small-multiply" } } */
>  /* { dg-options "-mcpu=cortex-m1.small-multiply -mthumb -Os" } */
>
>  int
> ========================================================

Reply via email to