> Regtested on x86_64-unknown-linux-gnu, Ok for trunk?

OK two me, with three comments:

>    * intrinsics/chmod.c (chmod_internal): New function, move logic
>    here.
>    (chmod_func): Call chmod_internal.

Not sure what’s the need / benefit from this, given the function is only called 
once.

>    * intrinsics/random.c (random_seed_i4): Use static buffer rather
>    than VLA, use _Static_assert to make sure it's big enough.

This array has constant size, known at compilation time. Isn’t it allowed to 
have an array with “const int” as size? I though it was.

>    * io/read.c (read_f): Likewise.

Is the known upper bound you have chosen (#define READF_TMP 50) compatible with 
the largest float we support, i.e. real(16)?
So that we avoid using allocation for reading data we have written ourselves in 
default format :)


FX

Reply via email to