Moore, Catherine <[email protected]> writes:
> The patch looks good. Please fix up these couple of nits prior to
> committing.
OK, thanks for the second read through. One further amendment below, I'll
aim to commit later today.
> Index: gcc/config/mips/mips.c
> ===================================================================
> --- gcc/config/mips/mips.c (revision 217363)
> +++ gcc/config/mips/mips.c (working copy)
> @@ -18824,6 +19000,21 @@ mips_expand_vec_minmax (rtx target, rtx op0, rtx
> o
> emit_insn (gen_rtx_SET (VOIDmode, target, x)); }
>
> +/* Implement HARD_REGNO_CALLER_SAVE_MODE. */
> +
> +machine_mode
> +mips_hard_regno_caller_save_mode (unsigned int regno,
> + unsigned int nregs,
> + machine_mode mode) {
> + /* For performance, to avoid saving/restoring upper parts of a
> register,
> + we return MODE as save mode when MODE is not VOIDmode. */
>
> s/performance, to/performance, /
>
The second part of this sentence will need to change too I think:
For performance, avoid saving/restoring upper parts of a register
by returning MODE as save mode when the mode is known.
Thanks,
Matthew
