On Wed, Sep 24, 2014 at 02:40:14PM +0200, Andreas Arnez wrote:
> A few style aspects I'm not sure about:
>
> * Is it OK to use __builtin_popcount in tree.c?
Definitely not, you can use popcount_hwi instead, which for GCC
host compiler (>= 3.4) will use __builtin_popcount*, otherwise
fallback to a library function.
> * Is it acceptable to add such a specialized function as
> get_nearest_type_subqualifiers to the tree interface? Or would it be
> preferable to move it as a static function to dwarf2out.c, since
> that's the only user right now?
I agree it should be kept in dwarf2out.c, it is too specialized.
Jakub
