OK, I'll skip this patch for now as HAVE_DESIGNATED_INITIALIZERS should always be false, so there is no point in cleaning it up.
> -----Original Message----- > From: Marcus Shawcroft [mailto:marcus.shawcr...@gmail.com] > Sent: 04 September 2014 16:42 > To: Wilco Dijkstra > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH 3/4] AArch64: Cleanup inconsistent use of __extension__ > > On 4 September 2014 16:39, Marcus Shawcroft <marcus.shawcr...@gmail.com> > wrote: > > On 4 September 2014 15:45, Wilco Dijkstra <wdijk...@arm.com> wrote: > >> Cleanup inconsistent use of __extension__. > >> > >> ChangeLog: > >> 2014-09-04 Wilco Dijkstra <wdijk...@arm.com> > >> > >> * gcc/config/aarch64/aarch64.c: Cleanup use of __extension__. > > > > Write a proper ChangeLog entry please. > > /Marcus > > > Actually, on second thoughts, I think it better to just remove the > three lines of the first spurious instance of: > > #if HAVE_DESIGNATED_INITIALIZERS && GCC_VERSION >= 2007 > __extension__ > #endif > > and leave the other instances alone. > > /Marcus