Re: RFA: Add a common tls_referenced_p function

[Jeff Law]

On 07/24/14 09:44, Richard Sandiford wrote:

Three targets had the same for_each_rtx function to check for a TLS symbol.
This patch adds a generic version instead.

Some other targets have a variation that checks for target-specific
UNSPEC sequences too so I've left those alone.  They're all prefixed
by the target name so there's no name clash or ambiguity.

Tested on mips64-linux-gnu and via a cross-compiler for
powerpc64-linux-gnu and hppa64-hp-hpux11.23.  OK to install?

Thanks,
Richard


gcc/
        * rtl.h (tls_referenced_p): Declare.
        * rtlanal.c (tls_referenced_p_1, tls_referenced_p): New functions.
        * config/mips/mips.c (mips_tls_symbol_ref_1): Delete.
        (mips_cannot_force_const_mem): Use tls_referenced_p.
        * config/pa/pa-protos.h (pa_tls_referenced_p): Delete.
        * config/pa/pa.h (CONSTANT_ADDRESS_P): Use tls_referenced_p
        instead of pa_tls_referenced_p.
        * config/pa/pa.c (hppa_legitimize_address, pa_cannot_force_const_mem)
        (pa_emit_move_sequence, pa_emit_move_sequence): Likewise.
        (pa_legitimate_constant_p): Likewise.
        (pa_tls_symbol_ref_1, pa_tls_referenced_p): Delete.
        * config/rs6000/rs6000.c (rs6000_tls_referenced_p): Delete.
        (rs6000_cannot_force_const_mem, rs6000_emit_move)
        (rs6000_address_for_altivec): Use tls_referenced_p instead of
        rs6000_tls_referenced_p.
        (rs6000_tls_symbol_ref_1): Delete.

OK.
Jeff