On Sun, Jul 20, 2014 at 12:25 PM, Tom de Vries <tom_devr...@mentor.com> wrote:

> this patch fixes the problems in test-case
> gcc.target/i386/fuse-caller-save-xmm.c reported in PR 61827. I've removed
> the checks for cfi_def_cfa_offset, which were not robust enough for the
> different configurations.
>
> Furthermore, I've:
> - added checks for all insns that handle the xmm registers, to make sure
> we're
>   actually using the xmm1 register.
> - fixed the scan-assembler-not lines to allow both %esp and %rsp.

You can use "%\[re\]?sp" here. We know that only r and e are valid.

> - removed main, which was really only intended for the
>   fuse-caller-save-xmm-run.c test-case.
>
> Tested with -m32 and -m64.

Probably you should also add -fomit-frame-pointer, otherwise the test
(that checks for SP based address) will fail on Darwin and Solaris
that default to frame pointers.

> OK for trunk?

OK with the above changes.

Thanks,
Uros.

Reply via email to