The gcov_info chain is not duplicated -- there is already one chain (linking only modules of the library) per shared library in current implementation. My change does not affect underlying behavior at all -- it merely introduces a new interface to access private dumper methods associated with shared libs.
David On Sun, Jul 20, 2014 at 12:42 PM, Nathan Sidwell <nat...@acm.org> wrote: > On 07/18/14 22:41, Xinliang David Li wrote: >> >> Hi, the following patch implements a new dumper interface to allow >> dumping of profile data for all instrumented shared libraries. >> >> For good reasons, existing libgcov implements the dumping on a >> per-shared library basis (i.e., gcov_exit is hidden, gcov_list is file >> static). This allows each shared library's profile data to be dumped >> independently with separate summary data. The downside is that there >> is no interface that can be invoked to dump profile data for all >> shared modules. > > > This seems like useful functionality, but I don't think this is the right > way to do this. You're duplicating the gcov info object chain. Why can't > you expose gcov_list from gcov-driver.c (possibly with a different name, of > course? > > nathan
