On Fri, Jun 20, 2014 at 11:34:26AM +0200, Marek Polacek wrote:
> On Fri, Jun 20, 2014 at 10:57:47AM +0200, Jakub Jelinek wrote:
> > On Fri, Jun 20, 2014 at 10:43:04AM +0200, Marek Polacek wrote:
> > > +
> > > + /* Internal function code. */
> > > + ENUM_BITFIELD(internal_fn) ifn : 5;
> >
> > Any reason for the " : 5" here? I mean, the union also contains
> > unsigned int, so it doesn't hurt if you use full 32 bits for it there,
> > and it should be faster and you won't run into problems when we'll have
> > more than 32 internal functions.
>
> The sole reason was that all other ENUM_BITFIELDs have it - on the
> other hand, they're not in a union and here the bit-field is
> pointless. I'll drop it.
Well, no point to use ENUM_BITFIELD either, just use
enum internal_fn ifn;
?
Jakub
