On Fri, Jun 20, 2014 at 10:43:04AM +0200, Marek Polacek wrote: > + > + /* Internal function code. */ > + ENUM_BITFIELD(internal_fn) ifn : 5;
Any reason for the " : 5" here? I mean, the union also contains
unsigned int, so it doesn't hurt if you use full 32 bits for it there,
and it should be faster and you won't run into problems when we'll have
more than 32 internal functions.
Otherwise the patch looks good to me, but please wait for comments
from Joseph and/or Jason.
Jakub
