On 05/20/14 20:12, Zhenqiang Chen wrote:
OK. It was more a question of clarity than efficiency. Your patch is fine as-is.In the code, there are 4 combinations of EDGE_COUNT: <1, 1>, <1, 2>, <2, 1> and <2, 2>. <2, 1> is "illegal". <2, 2> is legal, but need split_edge. <1, *> can bypass the second check. EDGE_CRITICAL_P can only distinguish <2, 2> from others.So I think two explicit checks is more efficient than EDGE_CRITICAL_P.
jeff