On Thu, May 15, 2014 at 9:28 AM, Yury Gribov <y.gri...@samsung.com> wrote: > On 05/14/2014 08:51 AM, Konstantin Serebryany wrote: >>> >>> One theme I have been noticing in the libsanitizer code is that it has >>> all of the knowledge of glibc when it comes to syscalls but makes some >>> bad assumptions dealing with some structures. For an example on MIPS >>> n64: stat and stat64 are different layout between user and kernel. >>> Don't ask, it is a historical mistake. >>> >>> Also it really forces target maintainers to maintain both glibc and >>> libsanitizer code. ILP32 on aarch64 has some similar issues as x32 >>> and MIPS n32. >>> Even Linus is pushing new 32bit targets to go the route of 64bit time >>> which is means libsanitizer code becomes even more complex. >> >> >> This is indeed a PITA. >> It is caused by our need to avoid even greater PITA of including >> system headers into the sanitizer files >> (we allow system #includes only in a handful of files). > > > Have you considered adding a configure-like step to your build process to > determine necessary sizes and then provide them to sanitizer files via some > config.h?
No. We have to support too many build systems and hence do not want any configure step. All configuration has to be done in the sources.
