On Fri, 2 May 2014, Marek Polacek wrote: > On Thu, May 01, 2014 at 10:54:18PM +0000, Joseph S. Myers wrote: > > I think the comment on this function should be updated to explain the > > interface contract when an incomplete (or function) type is passed (i.e. > > return size_one_node, caller is responsible for any diagnostics). > > Done. > > > The test should I think also cover incomplete union types, and pointer > > subtraction for all the different cases of incomplete types, and the += > > and -= operators (i.e. cover invalid arithmetic on pointers to incomplete > > types more thoroughly, even if not actually affected by this patch). > > Done. > > Another change is that I used COMPLETE_TYPE_P instead of > COMPLETE_OR_VOID_TYPE_P, that would be a bug and before it didn't make > much sense: we checked VOID_TYPE before. > > Tested x86_64-linux, ok now?
OK. -- Joseph S. Myers jos...@codesourcery.com
