On 01/09/2014 03:34 PM, Jakub Jelinek wrote: > 2014-01-09 Jakub Jelinek <ja...@redhat.com> > > * target-globals.c (save_target_globals): Allocate < 4KB structs using > GC in payload of target_globals struct instead of allocating them on > the heap and the larger structs separately using GC. > * target-globals.h (struct target_globals): Make regs, hard_regs, > reload, expmed, ira, ira_int and lra_fields GTY((atomic)) instead > of GTY((skip)) and change type to void *. > (reset_target_globals): Cast loads from those fields to corresponding > types. > > --- gcc/target-globals.h.jj 2014-01-09 19:24:20.000000000 +0100 > +++ gcc/target-globals.h 2014-01-09 19:39:43.879348712 +0100 > @@ -41,17 +41,17 @@ extern struct target_lower_subreg *this_ > > struct GTY(()) target_globals { > struct target_flag_state *GTY((skip)) flag_state; > - struct target_regs *GTY((skip)) regs; > + void *GTY((atomic)) regs;
I'm not entirely fond of this either, for the obvious reason. Clearly a deficiency in gengtype, but after 2 hours of poking around I can see that it isn't a quick fix. I guess I'm ok with the patch, since the use of the target_globals structure is so restricted. r~