On Wed, Jan 08, 2014 at 07:41:26PM +0000, Richard Sandiford wrote: > Jakub Jelinek <ja...@redhat.com> writes: > > 2014-01-08 Jakub Jelinek <ja...@redhat.com> > > > > * target-globals.c (save_target_globals): Allocate most of the > > structs using GC in payload of target_globals struct instead > > of allocating them on the heap. > > Looks good to me FWIW. I don't know either way about the one-big-blob thing. > > Note that we'll still leak memory when deleting TARGET_OPTION_NODEs > because target_ira_int and target_lra_int have pointers to heap-allocated > storage.
Yeah, perhaps that is something to fix incrementally. But, at least we will not leak ~ 0.5MB per (unique) target attribute used on some unused function. Jakub