On Tue, Dec 24, 2013 at 6:50 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Tue, Dec 24, 2013 at 3:23 PM, H.J. Lu <hjl.to...@gmail.com> wrote: >> On Tue, Dec 24, 2013 at 6:12 AM, Uros Bizjak <ubiz...@gmail.com> wrote: >>> On Tue, Dec 24, 2013 at 2:08 PM, H.J. Lu <hongjiu...@intel.com> wrote: >>> >>>> cpu_names in i386.c is only used by ix86_function_specific_print which >>>> accesses it with enum processor_type index. But cpu_names is defined as >>>> array with enum target_cpu_default index. This patch adds processor >>>> names to processor_target_table and uses processor_target_table instead >>>> of cpu_names. It removes cpu_names and target_cpu_default. Tested on >>>> Linux/x86-64. OK to install? >>> >>> Wait a moment, >>> >>> it looks to me that TARGET_CPU_DEFAULT has to be synchronized with >>> const processor_alias_table, so we are able to define various ISA >>> extensions by selecting TARGET_CPU_*. The TARGET_CPU_DEFAULT can then >> >> TARGET_CPU_DEFAULT sets the default -mtune=, not -march=. >> >>> be used to select extensions in the same way as PROCESSOR_* selects >>> tuning for certain processor. >> >> It has been like this for a long time. For x86, TARGET_CPU_DEFAULT >> isn't defined no matter which configure options are used. We can >> change config.gcc to set TARGET_CPU_DEFAULT to proper PROCESSOR_XXX or >> set it to a string "xxx" for processor "xxx". >> But GCC driver always passes -march=/-mtune= to toplev.c so that >> TARGET_CPU_DEFAULT is normally used.
I meant to say "TARGET_CPU_DEFAULT isn't normally used." > > Let me rethink this a bit, please do not commit the patch. > > Uros. Sure. -- H.J.
