On Wed, Dec 18, 2013 at 1:46 PM, Yvan Roux <yvan.r...@linaro.org> wrote: > Hi, > > this patch from Vladimir fixes an ICE when compiling newlib in Thumb1. > It returns NO_REGS in THUMB_SECONDARY_OUTPUT_RELOAD_CLASS, the same > way we did for THUMB_SECONDARY_INPUT_RELOAD_CLASS.
This is OK if there are no regressions for Thumb1. I'd also like to see some more documentation about lra_in_progress vs reload_in_progress but I realize that's been discussed earlier elsewhere. Thanks, Ramana > > The testsuite is OK with this patch, but as we have also a regression > on iWMMXT, I tried to avoid the secondary reload restriction at a > higher level : in SECONDARY_[INPUT|OUTPUT]_RELOAD_CLASS, as these > macros handle the iWMMXT target. Unfortunately it doesn't fix the > issue, but the testsuite results are the same as with the attached > patch. > > It seems to me that this second solution is more LRA friendly (i.e. > doing less thing on the target side) but I want your opinion. > > If the Thumb fix is sufficient, here is the Changelog > > 2013-12-18 Vladimir Makarov <vmaka...@redhat.com> > > * config/arm/arm.h (THUMB_SECONDARY_OUTPUT_RELOAD_CLASS): Return > NO_REGS > for LRA. > > Thanks, > Yvan
