On 12/15/2013 07:40 PM, Iyer, Balaji V wrote:
-                      tree clauses, tree *cclauses)
+                      tree clauses_or_grain, tree *cclauses)

Instead of this, please make the grainsize a new type of clause.

-  return (gimple_omp_subcode (g) & GF_OMP_FOR_COMBINED) != 0;
+  return (gimple_omp_for_kind (g) == GF_OMP_FOR_COMBINED);

I don't really know this code, but this change seems unlikely to be correct. Can you explain it?

+  tree data_name = get_identifier (".omp_data_i");
+  if (is_cilk_for)
+    data_name = get_identifier (".cilk_for_data_i");

Why does the name of an artificial parameter matter?

 }
+/* A subroutine of expand_omp_for.  Generate code for _Cilk_for loop.
+   Given parameters:

Need a blank line after the }.

Jason

Reply via email to