2013/12/11 Monk Chiang <sh.chian...@gmail.com>: > Hi, > > Recently I used --target=nds32be-elf to configure nds32 gcc, > it seems that the big endian is not set as default. > [...] > > The following is the patch to fix this issue. Tested on nds32be-elf. > > OK to apply? > > Index: common/config/nds32/nds32-common.c > =================================================================== > --- common/config/nds32/nds32-common.c (revision 205880) > +++ common/config/nds32/nds32-common.c (working copy) > @@ -93,7 +93,8 @@ > TARGET_CMOV : Generate conditional move instruction. */
Could you also extend the comment about adding TARGET_CPU_DEFAULT? That would be great to let other developers realize why we need it. :) > #undef TARGET_DEFAULT_TARGET_FLAGS > #define TARGET_DEFAULT_TARGET_FLAGS \ > - (MASK_GP_DIRECT \ > + (TARGET_CPU_DEFAULT \ > + | MASK_GP_DIRECT \ > | MASK_16_BIT \ > | MASK_PERF_EXT \ > | MASK_CMOV) > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 205880) > +++ ChangeLog (working copy) > @@ -1,3 +1,8 @@ > +2013-12-11 Monk Chiang <sh.chian...@gmail.com> In ChangeLog formatting, there should be two spaces between 'Chiang' and '<'. > + > + * common/config/nds32/nds32-common.c (TARGET_DEFAULT_TARGET_FLAGS): > + Redefine. > + Suggest using 'Consider TARGET_CPU_DEFAULT settings.' > 2013-12-11 Bin Cheng <bin.ch...@arm.com> > OK with those changes. Thank you for the patch fixing that issue. :) Best regards, jasonwucj
