Hi, I'm getting a bootstrap fail with Go with our custom patched
compiler (it adds that warning):
09:48 < richi> ../../../libgo/runtime/go-signal.c: In function
'runtime_sighandler':
09:48 < richi> ../../../libgo/runtime/go-signal.c:221:4: error: call to
function 'runtime_traceback' without a real prototype
[-Werror=unprototyped-calls] runtime_traceback (g);
which is because the declaration of runtime_traceback looks like
void runtime_traceback();
and thus if you call it the compiler doesn't know the number of
arguments or their types and thus unwanted promotions may apply
that change calling conventions (for example float -> double).
In this case the argument is a pointer, so it's probably not
an issue. Still the above is not a prototype which the patch
below fixes.
Bootstrap/testing in progress on x86_64-unknown-linux-gnu
(let's hope this was the only one).
Ian, please merge.
Thanks,
Richard.
2013-12-03 Richard Biener <rguent...@suse.de>
libgo/
* runtime/runtime.h (runtime_traceback): Prototype properly.
Index: libgo/runtime/runtime.h
===================================================================
--- libgo/runtime/runtime.h (revision 205585)
+++ libgo/runtime/runtime.h (working copy)
@@ -453,7 +453,7 @@ enum {
};
void runtime_hashinit(void);
-void runtime_traceback();
+void runtime_traceback(G*);
void runtime_tracebackothers(G*);
/*
