Thanks for doing this conversion work. A few questions and comments: 1) Because rs6000 is one of the few ports that was completely converted to wide-int instead of simply accommodating wide-int, what is the compile-time performance impact of this conversion?
2) non_logical_cint_operand changed const_double to const_wide_int, it did not add the additional CODE. Mike explained why in a private conversation, but the ChangeLog should be corrected. 3) altivec_resolve_overloaded_builtin, both hunks should be converted the same way, using tree_fits_uhwi_p - && TREE_CODE (arg2) == INTEGER_CST - && TREE_INT_CST_HIGH (arg2) == 0 - && (TREE_INT_CST_LOW (arg2) == 0 || TREE_INT_CST_LOW (arg2) == 1)) + && tree_fits_uhwi_p (arg2) + && wi::ltu_p (arg2, 2)) 4) easy_altivec_constant, the comment about 32 bit should be removed because wide-int should remove the dependency on 32 bit vs 64 bit host wide int. 5) rs6000_aggregate_candidate, is this change correct for Ada and non-constant type size? The rest looks good. I'd like to see the revised patch before approving. Thanks, David On Sat, Nov 23, 2013 at 2:22 PM, Mike Stump <mikest...@comcast.net> wrote: > Richi has asked the we break the wide-int patch so that the individual port > and front end maintainers can review their parts without have to go through > the entire patch. This patch covers the rs6000 port. > > Ok? >
