> -----Original Message----- > From: Richard Biener [mailto:richard.guent...@gmail.com] > Sent: 15 October 2013 10:12 > To: Paolo Carlini > Cc: Paulo Matos; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] tree_code_name wrapper > > > Apart from this please make sure to properly use tabs to indent: > > @@ -9098,7 +9098,8 @@ dump_tree_statistics (void) > fprintf (stderr, "Code Nodes\n"); > fprintf (stderr, "----------------------------\n"); > for (i = 0; i < (int) MAX_TREE_CODES; i++) > - fprintf (stderr, "%-20s %7d\n", tree_code_name[i], > tree_code_counts[i]); > + fprintf (stderr, "%-20s %7d\n", get_tree_code_name ((enum tree_code) > i), > + tree_code_counts[i]); > fprintf (stderr, "----------------------------\n"); > > (maybe in other places, too). > > Also we write the shorter > > * tree-vrp.c (dump_asserts_for): Use new wrapper get_tree_code_name. > * tree-dump.c (dequeue_and_dump): Likewise. > > instead of duplicating the same sentence. > > Ok with that changes. >
Thanks, regarding the indentation I was convinced we used 2 space indentation with maximum line length of 80 characters. I am not sure what the problem is with the hunk you copied above. Should I also submit several change logs to gcc-patches like: For gcc/ 2013-10-15 Paulo Matos <pma...@broadcom.com> * ... For gcc/cp/ 2013-10-15 Paulo Matos <pma...@broadcom.com> * ... -- Paulo Matos