Re: [PATCH] tree_code_name wrapper

[Richard Biener]

On Mon, Oct 14, 2013 at 6:10 PM, Paolo Carlini <paolo.carl...@oracle.com> wrote:
> Hi
>
>
> On 10/14/2013 05:43 PM, Paulo Matos wrote:
>>
>>         * cp/error.c (code_to_string): Use new wrapper get_tree_code_name.
>>         * cp/cxx-pretty-print.c (pp_cxx_assignment_operator): Use new
>> wrapper get_tree_code_name.
>>         * cp/pt.c (tsubst): Use new wrapper get_tree_code_name.
>>         * cp/semantics.c (cxx_eval_constant_expression,
>> potential_constant_expression_1): Use new
>>         wrapper get_tree_code_name.
>>         * cp/mangle.c (MANGLE_TRACE_TREE, dump_substitution_candidates,
>> add_substitution,
>>         find_substitution): Use new wrapper get_tree_code_name.
>
> In general, if you touch files in subdirectories which have separate
> ChangeLog files you have to prepare separate ChangeLog entries (and then,
> considering the present case as an example, you don't have cp/ at the
> beginning of the corresponding file names)

Apart from this please make sure to properly use tabs to indent:

@@ -9098,7 +9098,8 @@ dump_tree_statistics (void)
       fprintf (stderr, "Code                   Nodes\n");
       fprintf (stderr, "----------------------------\n");
       for (i = 0; i < (int) MAX_TREE_CODES; i++)
-       fprintf (stderr, "%-20s %7d\n", tree_code_name[i], tree_code_counts[i]);
+       fprintf (stderr, "%-20s %7d\n", get_tree_code_name ((enum tree_code) i),
+                 tree_code_counts[i]);
       fprintf (stderr, "----------------------------\n");

(maybe in other places, too).

Also we write the shorter

        * tree-vrp.c (dump_asserts_for): Use new wrapper get_tree_code_name.
        * tree-dump.c (dequeue_and_dump): Likewise.

instead of duplicating the same sentence.

Ok with that changes.

Thanks,
Richard.

> Paolo.