Re: [RFC, middlend] Fix for PR54218

[Andrew Pinski]

On Fri, Jan 11, 2013 at 8:17 AM, George Thomas
<georgethomas....@gmail.com> wrote:
> Hi,
>
> I am sending a patch which solves the debugging issue (PR 54218).
>
> The fix is to allocate stack space only once for parameters in expand pass.
>
> The patch is attached. Could someone suggest if its right ?

I have just a formatting issue:
+         if (TREE_CODE (SSA_NAME_VAR (var)) != PARM_DECL)
+          {
+            if (!bitmap_bit_p (SA.partition_has_default_def, i))

I think it would have been better if you had done instead:
          if (TREE_CODE (SSA_NAME_VAR (var)) != PARM_DECL
             && !bitmap_bit_p (SA.partition_has_default_def, i))

So there are no other white space changes.

Also missing a changelog entry too.

Thanks,
Andrew