On Wed, Nov 14, 2012 at 3:11 AM, H.J. Lu <hjl.to...@gmail.com> wrote:
> On Mon, Nov 12, 2012 at 10:59 AM, H.J. Lu <hjl.to...@gmail.com> wrote:
>> On Mon, Nov 12, 2012 at 3:47 AM, Dodji Seketeli <do...@seketeli.org> wrote:
>>> Diego Novillo <dnovi...@google.com> writes:
>>>
>>>> On 2012-11-02 16:10 , Dodji Seketeli wrote:
>>>>
>>>>> * configure.ac: Add libsanitizer to target_libraries.
>>>>> * Makefile.def: Ditto.
>>>>> * configure: Regenerate.
>>>>> * Makefile.in: Regenerate.
>>>>> * libsanitizer: New directory for asan runtime. Contains an empty
>>>>> tsan directory.
>>>>>
>>>>> gcc:
>>>>> * gcc.c (LINK_COMMAND_SPEC): Add -lasan to link command
>>>>> if -faddress-sanitizer is on.
>>>>
>>>> OK with Jakub's comments addressed.
>>>>
>>>> References to -fasan in diagnostics should be replaced. But there's
>>>> been another flag name change upstream, so let's do it together with
>>>> the new flag names.
>>>
>>> Done. This also addresses the comment later made by Tobias below:
>>>
>>> Tobias Burnus <bur...@net-b.de> writes:
>>>
>>>> Other issues:
>>>
>>>> * Probably fixed on the branch: gcc/gcc.c still has "fasan" instead of
>>>> "faddress-sanitizer" for the spec:
>>>> + %{fasan:-lasan}
>>>
>>> Below is a link to the updated patch.
>>>
>>> This patch imports the runtime library in the GCC tree, ensures that
>>> -lasan is passed to the linker when -faddress-sanitizer is used and
>>> sets up the build system accordingly.
>>>
>>> * configure.ac: Add libsanitizer to target_libraries.
>>> * Makefile.def: Ditto.
>>> * configure: Regenerate.
>>> * Makefile.in: Regenerate.
>>> * libsanitizer: New directory for asan runtime. Contains an empty
>>> tsan directory.
>>>
>>> gcc:
>>> * gcc.c (LINK_COMMAND_SPEC): Add -laddress-sanitizer to link command
>>> if -faddress-sanitizer is on.
>>>
>>> libsanitizer:
>>>
>>> Initial checkin: migrate asan runtime from llvm.
>>>
>>> http://people.redhat.com/~dseketel/gcc/patches/0011-Import-the-asan-runtime-library-into-GCC-tree.patch
>>>
I renamed ChangeLog.asan to ChangeLog.
--
H.J.
