> I noticed that in r151350, Micheal changed from set_expr_location_r to > SET_EXPR_LOCATION. Any insights why the recursive call is replaced? > Looks to me if we reset the location for first level expr here, there > is no reason that we don't reset expr for deeper levels. Or shall we > simply remove SET_EXPR_LOCATION?
Certainly overwriting an existing location with another one looks very wrong. And even propagating a toplevel location onto nested nodes without location can be problematic if you jump over a different location in the tree. We don't need to put a location on every single node before RTL expansion, since RTL insns inherit the current location, so I'm not sure what you are trying to achieve here. Fixing specific issues with changes like the one you posted for tree-eh.c is the way to go instead. -- Eric Botcazou
