> From:Michiel Derhaeg <[email protected]> > Send Time:Wed, May 20, 2026, 18:16 > To:"[email protected]"<[email protected]>; Jin > Ma<[email protected]> > CC:"[email protected]"<[email protected]> > Subject:Re: [PATCH 1/2] RISC-V: Fix multiple bugs in riscv_macro_fusion_pair_p > > Hi Jin, > > > Thanks for the review. > Know that I'm not a RISC-V port reviewer. I can't approve your patches.
I've always known that. > I'm just providing opinions, you're free to disagree with me :p That's exactly why I CC'd you. :) > > Since the core logic remains largely unchanged (aside from these fixes), I > > initially believed the existing test suite would be sufficient. > If you found bugs, they're clearly insufficient. That's a bit the problem, > most of these fusion checks are lacking tests. > > > That said, if you feel that specific test cases are necessary to validate > > these fixes, I am happy to add them. Please let me know if you would like > > me to update this patch with new tests. > Please do, would be useful. That makes a lot of sense. I'll give it a try, though it seems like it won't be straightforward. :) BR, Jin
