Hi Jin,

> Thanks for the review.
Know that I'm not a RISC-V port reviewer. I can't approve your patches. 
I'm just providing opinions, you're free to disagree with me :p

> Since the core logic remains largely unchanged (aside from these fixes), I
> initially believed the existing test suite would be sufficient.
If you found bugs, they're clearly insufficient. That's a bit the problem, 
most of these fusion checks are lacking tests.

> That said, if you feel that specific test cases are necessary to validate
> these fixes, I am happy to add them. Please let me know if you would like
> me to update this patch with new tests.
Please do, would be useful.

Thanks,
Michiel

Reply via email to